milenkovicm commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102672197
>
> My final answer for today is
>
> ```rust
> fn simplify(
> &self,
> args: AggregateArgs,
> _info: &dyn SimplifyInfo,
> ) -> Option<Box<dyn Fn(AggregateArgs) -> Result<Expr>>> {
> ```
>
> Go with optional closure!
you mean
```rust
// UDF
fn simplify(
&self,
) -> Option<Box<dyn Fn(AggregateFunction, &dyn SimplifyInfo) ->
Result<Expr>>> {
```
or
```rust
// UDF
fn simplify(
&self,
info: &dyn SimplifyInfo
) -> Option<Box<dyn Fn(AggregateFunction) -> Result<Expr>>> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
