jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102684929

   It should be this.
   ```rust
   // UDF
   fn simplify(
           &self,
       ) -> Option<Box<dyn Fn(AggregateFunction, &dyn SimplifyInfo) -> 
Result<Expr>>> {
   ```
   
   The reason for optional closure is that I assume we need to return `Expr` 
for simplified cases. If we expect `AggregateArgs`, then we might not need 
closure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to