jayzhan211 commented on PR #10354:
URL: https://github.com/apache/datafusion/pull/10354#issuecomment-2102701229
> We're on the same page @jayzhan211
If we don't need `Expr` for simplified UDAF, than we can have
```rust
pub fn simplify(
&self,
args: AggregateArgs,
info: &dyn SimplifyInfo,
) -> Result<Transformed<AggregateArgs>> {}
```
I think the next problem is whether we need `Expr` or just `AggregateArgs`.
The former can let us return the UDAF with a different function. But for this
kind of function rewrite, we can handle it in `FuncitonWrite`. You can see
`ArrayFunctionRewriter` for example.
@milenkovicm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
