andygrove commented on code in PR #383:
URL: https://github.com/apache/datafusion-comet/pull/383#discussion_r1598670410
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -563,9 +563,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateStrings(numericPattern, 8).toDF("a"),
DataTypes.BinaryType)
}
- ignore("cast StringType to DateType") {
+ test("cast StringType to DateType") {
// https://github.com/apache/datafusion-comet/issues/327
- castTest(generateStrings(datePattern, 8).toDF("a"), DataTypes.DateType)
+ castTest(
+ Seq(
+ "262142-01-01",
Review Comment:
Could you add some invalid entries here as well so that we can ensure that
Comet throws errors for invalid inputs when ANSI is enabled?
Some suggestions:
```scala
"",
"0",
"not_a_date",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
