kazuyukitanimura commented on code in PR #383:
URL: https://github.com/apache/datafusion-comet/pull/383#discussion_r1598893700
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -563,9 +563,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateStrings(numericPattern, 8).toDF("a"),
DataTypes.BinaryType)
}
- ignore("cast StringType to DateType") {
+ test("cast StringType to DateType") {
// https://github.com/apache/datafusion-comet/issues/327
- castTest(generateStrings(datePattern, 8).toDF("a"), DataTypes.DateType)
Review Comment:
Should we keep `generateStrings` because that covers random value tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
