kazuyukitanimura commented on code in PR #383: URL: https://github.com/apache/datafusion-comet/pull/383#discussion_r1598910718
########## spark/src/main/scala/org/apache/comet/expressions/CometCast.scala: ########## @@ -119,7 +119,7 @@ object CometCast { Unsupported case DataTypes.DateType => // https://github.com/apache/datafusion-comet/issues/327 - Unsupported + Compatible() Review Comment: If we do not cover these cases in this PR, we should add a test with `ignore` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org