erratic-pattern commented on issue #10426: URL: https://github.com/apache/datafusion/issues/10426#issuecomment-2116144023
> I think there's nothing wrong about having a "display" infrastructure, but it shouldn't be used eagerly. As others pointed out, using a hash or any form of numeric ID would probably be better in many places. @crepererum I am working on moving away from string allocations in a number of the optimization rules and switching to `Hash` based implementations. Most of these use the `Expr::display_name` method which - maybe confusingly - doesn't actually use `Display` but instead uses an internal `create_name` function. It is similar to the `Display` implementation but has some differences. For instance, `Cast` expressions are ignored and column references are rendered with a different syntax. I would be interested in seeing the profile data you mentioned, especially those that use `Display` and `to_string ` as that might indicate that something else could be improved beyond the changes I am currently working on. Also since we're no longer talking about strictly `CommonSubexprEliminate` at this point, it might be a good idea to track this as a separate issue and link this discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
