Blizzara commented on code in PR #10531:
URL: https://github.com/apache/datafusion/pull/10531#discussion_r1608623644
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1277,7 +1404,84 @@ pub(crate) fn from_substrait_literal(lit: &Literal) ->
Result<ScalarValue> {
s,
)
}
- Some(LiteralType::Null(ntype)) => from_substrait_null(ntype)?,
+ Some(LiteralType::List(l)) => {
+ let element_dt: Option<&DataType> = match dt {
+ Some(DataType::List(l)) => Ok(Some(l.data_type())),
Review Comment:
Yeah, we already do that (look at the first element) if `dt` is not given. I
think the reason I included `dt` was because Substrait types don't include the
field names for structs, so not using `dt` would mean using something like
`names` and `name_idx` instead (like in from_substrait_type_with_names).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
