Blizzara commented on code in PR #10531: URL: https://github.com/apache/datafusion/pull/10531#discussion_r1611984584
########## datafusion/substrait/src/logical_plan/consumer.rs: ########## @@ -1277,7 +1404,84 @@ pub(crate) fn from_substrait_literal(lit: &Literal) -> Result<ScalarValue> { s, ) } - Some(LiteralType::Null(ntype)) => from_substrait_null(ntype)?, + Some(LiteralType::List(l)) => { + let element_dt: Option<&DataType> = match dt { + Some(DataType::List(l)) => Ok(Some(l.data_type())), Review Comment: This was because I wasn't handling empty lists properly (producer created Lists rather than EmptyList) - that was fixed in the Lists PR. Thanks for catching! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org