Blizzara commented on PR #10531: URL: https://github.com/apache/datafusion/pull/10531#issuecomment-2127582955
@jonahgao Thanks for the review - I pushed a new version but it builds on top of https://github.com/apache/datafusion/pull/10622 and https://github.com/apache/datafusion/pull/10640 so will need those merged and this rebased first before this PRs looks clean. This is mostly what it used to be with one more major change: I removed passing the datatype into from_substrait_literal and instead do the same thing with names as I did for from_substrait_type. That maybe seems a bit cleaner (even though I dislike the name handling, but I don't see a better way to deal with it based on how it works in Substrait :/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
