metegenez commented on code in PR #10650:
URL: https://github.com/apache/datafusion/pull/10650#discussion_r1613754503
##########
datafusion/core/src/datasource/file_format/csv.rs:
##########
@@ -301,13 +296,7 @@ impl CsvFormat {
while let Some(chunk) = stream.next().await.transpose()? {
let format = arrow::csv::reader::Format::default()
- .with_header(
- first_chunk
- && self
- .options
- .has_header
-
.unwrap_or(state.config_options().catalog.has_header),
- )
+ .with_header(first_chunk && self.options.has_header)
Review Comment:
What if there is a catalog option on header? This might not be tested in the
code since the SQL tests wouldn't cover here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
