ozankabak commented on code in PR #10650:
URL: https://github.com/apache/datafusion/pull/10650#discussion_r1614446423
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -170,7 +170,8 @@ impl PhysicalExpr for CastExpr {
let target_type = &self.cast_type;
let unbounded = Interval::make_unbounded(target_type)?;
- if source_datatype.is_numeric() && target_type.is_numeric()
+ if (source_datatype.is_numeric() || source_datatype == Boolean)
Review Comment:
@berkaysynnada let's add a test for this if there is none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
