tmi opened a new pull request, #10982: URL: https://github.com/apache/datafusion/pull/10982
## Which issue does this PR close? Closes #10951. ## Rationale for this change Just extends the existing functionality for parquet page data stats -- `int` cases were covered previously, I just add `float` cases in the same fashion. ## What changes are included in this PR? * Float64 was a breeze, just add a macro invocation and case branch, * Float32 needed additionally an extension of data generation option -- I hope I didn't miss it existing already, * Float16 got a bit messy and required something I'm not happy with. Unlike other data types, it's physically represented as `FixedByteLength` of 2 bytes, which doesn't behave like a primitive type. In particular, I needed to add a `.clone()` at a particular place, which required going from `ident` to `expr` in a macro, affecting all cases. I'm very open to suggestions here -- I haven't come up with a better idea myself yet. ## Are these changes tested? Yes, I extended the existing test coverage to the newly added cases. ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
