tshauck commented on code in PR #10982:
URL: https://github.com/apache/datafusion/pull/10982#discussion_r1645033584
##########
datafusion/core/tests/parquet/arrow_statistics.rs:
##########
@@ -614,6 +614,94 @@ async fn test_int_8() {
.run();
}
+#[tokio::test]
+async fn test_float_16() {
+ // This creates a parquet files of 1 column named f
+ let reader = TestReader {
+ scenario: Scenario::Float16,
+ row_per_group: 5,
+ }
+ .build()
+ .await;
+
+ Test {
+ reader: &reader,
+ // mins are [-5, -4, 0, 5]
+ expected_min: Arc::new(Float16Array::from(vec![
+ f16::from_f32(-5.),
+ f16::from_f32(-4.),
+ f16::from_f32(-0.),
+ f16::from_f32(5.),
+ ])),
+ // maxes are [-1, 0, 4, 9]
+ expected_max: Arc::new(Float16Array::from(vec![
+ f16::from_f32(-1.),
+ f16::from_f32(0.),
+ f16::from_f32(4.),
+ f16::from_f32(9.),
+ ])),
+ // nulls are [0, 0, 0, 0]
+ expected_null_counts: UInt64Array::from(vec![0, 0, 0, 0]),
+ // row counts are [5, 5, 5, 5]
+ expected_row_counts: Some(UInt64Array::from(vec![5, 5, 5, 5])),
+ column_name: "f",
+ check: Check::Both,
+ }
+ .run();
+}
+
+#[tokio::test]
+async fn test_float_32() {
+ // This creates a parquet files of 1 column named f
+ let reader = TestReader {
+ scenario: Scenario::Float32,
+ row_per_group: 5,
+ }
+ .build()
+ .await;
+
+ Test {
+ reader: &reader,
+ // mins are [-5, -4, 0, 5]
+ expected_min: Arc::new(Float32Array::from(vec![-5., -4., -0., 5.0])),
+ // maxes are [-1, 0, 4, 9]
+ expected_max: Arc::new(Float32Array::from(vec![-1., 0., 4., 9.])),
+ // nulls are [0, 0, 0, 0]
+ expected_null_counts: UInt64Array::from(vec![0, 0, 0, 0]),
+ // row counts are [5, 5, 5, 5]
+ expected_row_counts: Some(UInt64Array::from(vec![5, 5, 5, 5])),
+ column_name: "f",
+ check: Check::Both,
+ }
+ .run();
+}
+
+#[tokio::test]
+async fn test_float_64() {
Review Comment:
There's a similar `test_float64` in this file that could similarly be
updated or removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
