tshauck commented on code in PR #10982:
URL: https://github.com/apache/datafusion/pull/10982#discussion_r1645032465


##########
datafusion/core/tests/parquet/arrow_statistics.rs:
##########
@@ -614,6 +614,94 @@ async fn test_int_8() {
     .run();
 }
 
+#[tokio::test]

Review Comment:
   I think this test is mostly a duplicate of `test_float16` just that one has 
`Check::RowGroup` vs ``Check::Both`... maybe one or the other can be updated?



##########
datafusion/core/tests/parquet/arrow_statistics.rs:
##########
@@ -614,6 +614,94 @@ async fn test_int_8() {
     .run();
 }
 
+#[tokio::test]

Review Comment:
   I think this test is mostly a duplicate of `test_float16` just that one has 
`Check::RowGroup` vs `Check::Both`... maybe one or the other can be updated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to