tshauck commented on code in PR #11229:
URL: https://github.com/apache/datafusion/pull/11229#discussion_r1663073768
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -97,7 +97,10 @@ impl Default for Count {
impl Count {
pub fn new() -> Self {
Self {
- signature: Signature::variadic_any(Volatility::Immutable),
+ signature: Signature::one_of(
Review Comment:
This is necessary so that the planner doesn't initially fail the query. It
shouldn't progress to that point, but perhaps there's a good way to add an
error if `Count` does get called with empty args?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
