tshauck opened a new pull request, #11229:
URL: https://github.com/apache/datafusion/pull/11229

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #11228
   
   ## Rationale for this change
   
   Adds an analyzer rule that roughly matches the current `CountWildcardRule` 
rule. I made them separate, but at first blush they could be combined. 
   
   I'm not sure how best to handle expressions in rust-land however, because 
right now the `count` function takes an expression as an input.
   
   ## What changes are included in this PR?
   
   * adds `CountEmptyRule`
   * basic slt tests
   * quick cleanup on `CountWildcardRule` that this is modeled after
   
   ## Are these changes tested?
   
   Added some slt tests, though need to add more.
   
   ## Are there any user-facing changes?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to