tshauck commented on PR #11229: URL: https://github.com/apache/datafusion/pull/11229#issuecomment-2206904296
@jayzhan211 thanks for the feedback. I like the idea because it would seem to avoid having to update the count function to accept zero args. The current approach is nice at least in that it's very clear what's happening (at least to me) and while a bit of code it's mostly a single chunk. Can you say more about new planner trait and how that'd be used? Is the idea I'd implement `UserDefinedSQLPlanner` for a new struct like `CountPlanner`? Also, since this is somewhat inspired from duckdb, they do a `count_star()` function that is distinct from and is an alias for `count()`. This approach may be nice in that I'd afford the opportunity to have a dataframe expression itself and also wouldn't require updating the args for `count`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
