mbutrovich commented on code in PR #3368:
URL: https://github.com/apache/datafusion-comet/pull/3368#discussion_r2758854743
##########
Makefile:
##########
@@ -51,26 +51,26 @@ format:
# build native libs for amd64 architecture Linux/MacOS on a Linux/amd64
machine/container
core-amd64-libs:
- cd native && cargo build -j 2 --release $(FEATURES_ARG)
+ cd native && RUSTFLAGS="-Ctarget-cpu=x86-64-v3" cargo build -j 2
--release $(FEATURES_ARG)
ifdef HAS_OSXCROSS
rustup target add x86_64-apple-darwin
cd native && cargo build -j 2 --target x86_64-apple-darwin --release
$(FEATURES_ARG)
endif
# build native libs for arm64 architecture Linux/MacOS on a Linux/arm64
machine/container
core-arm64-libs:
- cd native && cargo build -j 2 --release $(FEATURES_ARG)
+ cd native && RUSTFLAGS="-Ctarget-cpu=neoverse-n1" cargo build -j 2
--release $(FEATURES_ARG)
ifdef HAS_OSXCROSS
rustup target add aarch64-apple-darwin
cd native && cargo build -j 2 --target aarch64-apple-darwin --release
$(FEATURES_ARG)
endif
core-amd64:
rustup target add x86_64-apple-darwin
- cd native && RUSTFLAGS="-Ctarget-cpu=skylake
-Ctarget-feature=-prefer-256-bit" CC=o64-clang CXX=o64-clang++ cargo build
--target x86_64-apple-darwin --release $(FEATURES_ARG)
+ cd native && RUSTFLAGS="-Ctarget-cpu=skylake" CC=o64-clang
CXX=o64-clang++ cargo build --target x86_64-apple-darwin --release
$(FEATURES_ARG)
mkdir -p common/target/classes/org/apache/comet/darwin/x86_64
cp native/target/x86_64-apple-darwin/release/libcomet.dylib
common/target/classes/org/apache/comet/darwin/x86_64
- cd native && RUSTFLAGS="-Ctarget-cpu=haswell
-Ctarget-feature=-prefer-256-bit" cargo build --release $(FEATURES_ARG)
+ cd native && RUSTFLAGS="-Ctarget-cpu=x86-64-v3" cargo build --release
$(FEATURES_ARG)
Review Comment:
This is for local development I guess, but made consistent. Also this flag
doesn't make sense on this target (Haswell), so I suspect it's mistakenly
copy-pasted from elsewhere.
##########
Makefile:
##########
@@ -51,26 +51,26 @@ format:
# build native libs for amd64 architecture Linux/MacOS on a Linux/amd64
machine/container
core-amd64-libs:
- cd native && cargo build -j 2 --release $(FEATURES_ARG)
+ cd native && RUSTFLAGS="-Ctarget-cpu=x86-64-v3" cargo build -j 2
--release $(FEATURES_ARG)
ifdef HAS_OSXCROSS
rustup target add x86_64-apple-darwin
cd native && cargo build -j 2 --target x86_64-apple-darwin --release
$(FEATURES_ARG)
endif
# build native libs for arm64 architecture Linux/MacOS on a Linux/arm64
machine/container
core-arm64-libs:
- cd native && cargo build -j 2 --release $(FEATURES_ARG)
+ cd native && RUSTFLAGS="-Ctarget-cpu=neoverse-n1" cargo build -j 2
--release $(FEATURES_ARG)
ifdef HAS_OSXCROSS
rustup target add aarch64-apple-darwin
cd native && cargo build -j 2 --target aarch64-apple-darwin --release
$(FEATURES_ARG)
endif
core-amd64:
rustup target add x86_64-apple-darwin
- cd native && RUSTFLAGS="-Ctarget-cpu=skylake
-Ctarget-feature=-prefer-256-bit" CC=o64-clang CXX=o64-clang++ cargo build
--target x86_64-apple-darwin --release $(FEATURES_ARG)
+ cd native && RUSTFLAGS="-Ctarget-cpu=skylake" CC=o64-clang
CXX=o64-clang++ cargo build --target x86_64-apple-darwin --release
$(FEATURES_ARG)
Review Comment:
This flag doesn't make sense on this target (Skylake), so I suspect it's
mistakenly copy-pasted from elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
