kosiew commented on code in PR #20814:
URL: https://github.com/apache/datafusion/pull/20814#discussion_r2903615208
##########
datafusion/physical-expr/src/equivalence/properties/mod.rs:
##########
@@ -844,32 +864,10 @@ impl EquivalenceProperties {
let expr_type = sort_expr.expr.data_type(schema).unwrap();
// TODO: Add one-to-one analysis for ScalarFunctions.
for r_expr in referring_exprs {
- // We check whether this expression is substitutable.
- if let Some(cast_expr) =
- r_expr.as_any().downcast_ref::<CastExpr>()
- {
- // For casts, we need to know whether the cast
Review Comment:
👍
I’ll add that rationale to the helper so the optimization rule stays
readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
