kosiew commented on PR #20814: URL: https://github.com/apache/datafusion/pull/20814#issuecomment-4021788658
@adriangb Thanks for the review. I found one behavior change worth addressing before merging. - `CastExpr::nullable()` now returns `resolved_target_field(...).is_nullable()`. - That means a field-aware cast can now report `false` purely because the target field is marked non-nullable, even when the child expression is nullable and a regular `CAST` can still yield null for null input. - This diverges from the logical cast behavior which explicitly propagates the input nullability rather than forcing the destination field nullability. Can you review https://github.com/apache/datafusion/pull/20814/commits/3f8d73569f3e41411eda269c1a747375d2b3276b too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
