kosiew commented on code in PR #20814:
URL: https://github.com/apache/datafusion/pull/20814#discussion_r2903617183
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -92,10 +93,23 @@ impl CastExpr {
expr: Arc<dyn PhysicalExpr>,
cast_type: DataType,
cast_options: Option<CastOptions<'static>>,
+ ) -> Self {
+ Self::new_with_target_field(
+ expr,
+ cast_type.into_nullable_field_ref(),
+ cast_options,
+ )
+ }
+
+ /// Create a new CastExpr with an explicit target field.
Review Comment:
Yes, I’ll update both doc comments so they cross-reference each other and
make the intended usage explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
