peterxcli commented on code in PR #5039:
URL: https://github.com/apache/datafusion-comet/pull/5039#discussion_r3721333078


##########
spark/src/main/scala/org/apache/comet/serde/datetime.scala:
##########
@@ -968,6 +968,33 @@ object CometMakeYMInterval extends 
CometCodegenDispatch[MakeYMInterval]
 
 object CometMakeDTInterval extends CometCodegenDispatch[MakeDTInterval]
 
+object CometMakeInterval extends CometExpressionSerde[MakeInterval] {

Review Comment:
   Thanks for the direction! I'd like to take the mixin approach. feel free to 
close #5260.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to