peterxcli commented on PR #5039: URL: https://github.com/apache/datafusion-comet/pull/5039#issuecomment-5196880857
@andygrove thanks for the prompt another round of review, addressed all of your latest review, please take another look. btw I opened https://github.com/apache/datafusion-comet/issues/5279 per https://github.com/apache/datafusion-comet/pull/5039#discussion_r3722969753, which aims to implement a new `CometCalendarIntervalType` with the microsec precision and get rid of arrow's `CalendarIntervalType` with the nanosec precision. then we can support full native path for `make_interval` and have a safe intermediate data type in comet. it will also solve https://github.com/apache/datafusion-comet/issues/5131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
