peterxcli commented on PR #5039: URL: https://github.com/apache/datafusion-comet/pull/5039#issuecomment-5193608644
Thanks @andygrove ! I pushed new commit addressing the latest review. CometMakeInterval now mixes in CodegenDispatchFallback, so the compatible path uses JVM codegen dispatch by default and the native kernel remains opt-in. This should make #5260 unnecessary. I also: - widened the incompatibility warning and #5131 description to cover hours, minutes, and seconds; - documented and tested try_make_interval, including ANSI mode returning NULL; - added the ignored hours-overflow case; - tightened the ANSI checks to ARITHMETIC_OVERFLOW; - documented why the native wrapper reports interval overflow; - removed the unreachable registry registration. Mode | Best time | Throughput | Relative -- | -- | -- | -- Spark | 62 ms | 16.9 M rows/s | 1.0x Codegen dispatch | 28 ms | 37.4 M rows/s | 2.2x Native | 24 ms | 43.6 M rows/s | 2.6x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
