xavlee commented on code in PR #24697:
URL: https://github.com/apache/datafusion/pull/24697#discussion_r3915396779
##########
datafusion/physical-plan/src/aggregates/ordered_final_stream.rs:
##########
@@ -35,16 +35,16 @@ use super::AggregateExec;
use super::aggregate_hash_table::{
FinalMarker, OrderedAggregateTable, OrderedAggregateTableMetrics,
};
+use super::order::GroupCompletionMode;
use crate::aggregates::AggregateMode;
use crate::metrics::{BaselineMetrics, RecordOutput, SpillMetrics};
use crate::sorts::IncrementalSortIterator;
use crate::sorts::streaming_merge::{SortedSpillFile, StreamingMergeBuilder};
use crate::spill::spill_manager::SpillManager;
use crate::stream::EmptyRecordBatchStream;
-use crate::{InputOrderMode, RecordBatchStream, SendableRecordBatchStream};
+use crate::{RecordBatchStream, SendableRecordBatchStream};
-/// Final aggregate stream for `InputOrderMode::Sorted` and
-/// `InputOrderMode::PartiallySorted`.
+/// Final aggregate stream for input whose completed group ranges can be
identified.
Review Comment:
Yes full and partial group completion modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
