xavlee commented on code in PR #24697: URL: https://github.com/apache/datafusion/pull/24697#discussion_r3915408722
########## datafusion/physical-plan/src/aggregates/order/mod.rs: ########## @@ -28,6 +28,33 @@ use crate::InputOrderMode; pub use full::GroupOrderingFull; pub use partial::GroupOrderingPartial; +/// Describes how an aggregate can determine that groups are complete. +/// Review Comment: Yeah agreed, I added a short example -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
