xavlee commented on code in PR #24697:
URL: https://github.com/apache/datafusion/pull/24697#discussion_r3915405957
##########
datafusion/physical-plan/src/aggregates/order/mod.rs:
##########
@@ -28,6 +28,33 @@ use crate::InputOrderMode;
pub use full::GroupOrderingFull;
pub use partial::GroupOrderingPartial;
+/// Describes how an aggregate can determine that groups are complete.
+///
+/// This is distinct from [`InputOrderMode`], which describes the ordering of
+/// the input relative to the grouping expressions. Input ordering is one way
+/// to establish a group-completion mode, but the execution machinery only
+/// needs to know when it can safely emit completed groups.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub(crate) enum GroupCompletionMode {
+ /// Groups cannot be completed before the input ends.
+ None,
+ /// Groups sharing the values at these grouping-expression indices form a
+ /// contiguous range.
Review Comment:
I updated the comments for each variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
