Visorgood commented on PR #6110:
URL:
https://github.com/apache/datafusion-comet/pull/6110#issuecomment-5800970713
All three fixed, thanks.
The checks now carry the reasoning inline: that this isn't a
shuffle-correctness check, and that the fallback is what keeps CometSort off a
collated key supportedSortType lets through.
You're right about the UDF comment – `scalaUDF.codegen.enabled` defaults to
true, so those tests are not at default config. Reworded to say what they
actually do: turning the dispatcher off is a stable way to get a partition key
with no serde, and the point is that nothing there depends on strict mode.
Fixed the same claim in the description.
Plan stability: both suites pass unchanged, so there is nothing to
regenerate.
CometTPCDSV1_4_PlanStabilitySuite, CometTPCDSV2_7_PlanStabilitySuite
Suites: completed 2, aborted 0
Tests: succeeded 129, failed 0
Full run of everything this touches, including CometCollationSuite:
Suites: completed 6, aborted 0
Tests: succeeded 252, failed 0
Ordering with #5802 is settled with @sam-1112 – this one first, then he
rebases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
