dwsmith1983 commented on code in PR #6116:
URL: https://github.com/apache/datafusion-comet/pull/6116#discussion_r4100386459
##########
native/core/src/parquet/schema_adapter.rs:
##########
@@ -890,6 +887,12 @@ impl PhysicalExprAdapterFactory for
SparkPhysicalExprAdapterFactory {
// to the original physical names. This is necessary because
downstream code
// (reassign_expr_columns) looks up columns by name in the actual
stream schema,
// which uses the original physical file column names.
+ //
+ // The check that a file carries field ids at all, which Spark's
`ParquetReadSupport`
+ // runs before anything else, lives in
`EagerPageIndexReader::get_metadata`, where the
+ // raw Parquet schema is at hand. By the time the schemas reach this
point the INT96
+ // coercion may have dropped the ids from container fields, so
`physical_file_schema`
+ // cannot answer that question.
Review Comment:
Dropped all three. The one line left on `any_root_field_has_id` says it is
root only on purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
