dwsmith1983 commented on PR #6116: URL: https://github.com/apache/datafusion-comet/pull/6116#issuecomment-5825649423
> The final diff no longer touches Iceberg. Agreed. The description now says so, `area:Iceberg` and `run-iceberg-tests` can go, and `run-spark-4.1-tests` stays. > `ParquetReadSuite` does not gain both halves of Spark's "global read/write flag should work correctly". Right. The description now says the suite does not gain that test. Its first half, a file without ids read with the flag on, is the shape of the existing port, which now also runs with the flag off. Its second half is Spark's own test in the Spark SQL jobs, and the copy at L2216 is gone. The rest of the review is taken as suggested. The requested side is now one proto bool from `ParquetUtils.hasFieldIds`, the options fields and the Arrow walk are gone, the error carries the file path, the scan tests are replaced by one reader test in Rust and the Scala cases you listed, and the assertion style is Spark's own throughout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
