unikdahal commented on code in PR #5318:
URL: https://github.com/apache/datafusion-comet/pull/5318#discussion_r4113084278
##########
spark/src/test/scala/org/apache/comet/CometIcebergWriteActionSuite.scala:
##########
@@ -793,16 +786,47 @@ class CometIcebergWriteActionSuite
withSQLConf(CometConf.COMET_ICEBERG_WRITE_SPLIT_OPERATOR_ENABLED.key ->
"false") {
coalesceInsert("native_cow_merge", Seq((1, "us-east", 10.0), (2,
"us-west", 20.0)))
}
- assertNativeWriteDoesNotEngage("native_cow_merge", Seq(1, 2, 3)) {
- spark.sql("""
- |MERGE INTO cat.db.native_cow_merge t
- |USING (SELECT 2 AS id, 'us-west' AS region, 200.0 AS amount UNION
ALL
- | SELECT 3 AS id, 'eu' AS region, 30.0 AS amount) s
- |ON t.id = s.id
- |WHEN MATCHED THEN UPDATE SET t.amount = s.amount
- |WHEN NOT MATCHED THEN INSERT (id, region, amount) VALUES (s.id,
s.region, s.amount)
- |""".stripMargin)
+
+ var snapshot: Option[WriteSnapshot] = None
Review Comment:
Added partitioned copy-on-write and merge-on-read parity coverage against a
Comet-disabled sibling table, including the clause/NULL cases. Also added
cardinality-violation coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
