unikdahal commented on PR #5318: URL: https://github.com/apache/datafusion-comet/pull/5318#issuecomment-5850576469
Thanks for the detailed review, @andygrove really appreciate you taking the time to test this across versions and cases. I've merged current `main`, so the conflict is resolved and have addressed your inline comments On the source duplication: I looked at moving the shared implementation out of the 3.5/4.0 roots, but there isn't currently a common source root that maps cleanly to exactly those two versions. Introducing another Maven source root just for this felt like more build-layout complexity than this PR warrants. So the remaining option is to keep the copies and enforce that they stay identical. I initially tried a direct diff in the CI workflow, but that felt a bit too one-off. Would you prefer a small reusable dev/ci source-parity check for this, or is an explicit CI diff sufficient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
