mhilton commented on PR #25692: URL: https://github.com/apache/datafusion/pull/25692#issuecomment-5872373228
I've been doing a bit of arithmetic and the point in time where wrapping actually becomes a problem is `2262-04-11T23:47:16Z`. I would suggest that data-sets that actually include dates in far-off-space-year 2262 are very much outnumbered by ones that don't. My suggestion is that we detect if we are using dates where wrapping would be a problem and drop into a version of the algorithm using i128 values instead. This will presumably incur a small performance hit which I'm sure advances in hardware will solve in the next 200 years. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
