viirya commented on PR #25692: URL: https://github.com/apache/datafusion/pull/25692#issuecomment-5882576464
A correction to my comment above: "can still become `NULL` only when its bin itself can't be represented" lumps two different cases together. With #25815, a non-null input can still become `NULL` when: - the correct bin is outside the range of the output type, e.g. a bin starting before the type's minimum value. There is no correct value to return here. - a month stride is applied to a value outside the range of chrono's `DateTime<Utc>` (about ±262,000 years). Like the original nanosecond overflow, this is a limit of the intermediate representation, only much narrower; #25855 tracks fixing it. Also, #25815 does not propagate ordering for negative month strides, since their output is not monotonic even for ordinary dates (#25856). Positive strides are unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
