mbutrovich commented on PR #26686: URL: https://github.com/apache/datafusion/pull/26686#issuecomment-6384714775
Thanks for the review @comphead! > The doc on `subsecond_part` still explains Int64 by the 60-second bound. Updated in [`date_part.rs`](https://github.com/apache/datafusion/blob/48ff4d8da0d3a990f6ef216e13ef4e1f5cbe758f/datafusion/functions/src/datetime/date_part.rs#L517-L520). > Coverage gaps worth one query each: `nanosecond` on a `MonthDayNano` past minus one minute (only -1.5 s is tested, and the `% 60_000_000_000` arm is new), `nanosecond` on a negative `DayTime` and one with a non-zero days field, `Timestamp(Microsecond)` sub-second parts, and `Time32`/`Time64` sub-second parts on an array with a NULL row. Added [negative and multi-day `DayTime` and `MonthDayNano` cases](https://github.com/apache/datafusion/blob/48ff4d8da0d3a990f6ef216e13ef4e1f5cbe758f/datafusion/sqllogictest/test_files/datetime/date_part.slt#L1327-L1353), [one query per timestamp unit with a NULL row](https://github.com/apache/datafusion/blob/48ff4d8da0d3a990f6ef216e13ef4e1f5cbe758f/datafusion/sqllogictest/test_files/datetime/date_part.slt#L1029-L1083), and [one query per time unit with a NULL row](https://github.com/apache/datafusion/blob/48ff4d8da0d3a990f6ef216e13ef4e1f5cbe758f/datafusion/sqllogictest/test_files/datetime/date_part.slt#L915-L950). The pre-1970 and Monrovia queries now cast a column per unit, because `VALUES` had coerced every row to `Timestamp(ns)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
