mbutrovich commented on code in PR #26686:
URL: https://github.com/apache/datafusion/pull/26686#discussion_r4367250542
##########
datafusion/functions/src/datetime/date_part.rs:
##########
@@ -891,6 +866,38 @@ mod tests {
}
}
+ /// `epoch` is NULL only for a NULL input, but the integer parts can be
NULL
+ /// for a non-null input, so they are always nullable.
+ #[test]
+ fn return_field_nullability() {
Review Comment:
> Could this move to the slt with the existing `DESCRIBE` idiom (see
`describe.slt`)?
Done in
[`date_part.slt`](https://github.com/apache/datafusion/blob/48ff4d8da0d3a990f6ef216e13ef4e1f5cbe758f/datafusion/sqllogictest/test_files/datetime/date_part.slt#L1638-L1654),
and the unit test is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
