mbutrovich commented on code in PR #26686:
URL: https://github.com/apache/datafusion/pull/26686#discussion_r4372453871
##########
datafusion/spark/src/function/datetime/date_part.rs:
##########
@@ -77,14 +76,11 @@ impl ScalarUDFImpl for SparkDatePart {
&self.signature
}
+ // The default `return_field_from_args` makes the result nullable, like the
+ // integer parts of `date_part`, which this simplifies to, because they can
+ // be NULL for a non-null input
fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> {
Review Comment:
Done. `return_type` is an `internal_err!` again, as on `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
