xudong963 commented on code in PR #16325:
URL: https://github.com/apache/datafusion/pull/16325#discussion_r2135409445
##########
datafusion/sql/src/select.rs:
##########
@@ -77,11 +82,29 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
}
// Process `from` clause
- let plan = self.plan_from_tables(select.from, planner_context)?;
+ let plan = self.plan_from_tables(select.from.clone(),
planner_context)?;
let empty_from = matches!(plan, LogicalPlan::EmptyRelation(_));
// Process `where` clause
- let base_plan = self.plan_selection(select.selection, plan,
planner_context)?;
+ let mut base_plan =
Review Comment:
"logical optimizer rule" mainly focuses on **Optimization**, I think it's
fair to rewrite during planning phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
