ahmed-mez commented on PR #16506: URL: https://github.com/apache/datafusion/pull/16506#issuecomment-3000017936
Thank you @alamb for reviewing and for running the benchmark. I will work on adding a test as a first step, that would also help us iterate and validate any changes later on. In general, performance vs reliability trade-offs depend heavily on the specific context and use cases. In my opinion, giving users the ability to make that decision themselves is a strong and flexible approach. In this case, the reliability concern isn’t minor. Avoiding stack overflows is critical, as they can bring down the entire process. Personally, I would gladly accept even more than a 1–2% slowdown in planning time to gain protection against such failures. I’d really appreciate it if DataFusion provided a "knob" that allowed users to express this kind of preference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
