zhuqi-lucas commented on PR #16599:
URL: https://github.com/apache/datafusion/pull/16599#issuecomment-3015221855

   > Actually I am now torn about this as it will further diverge 
datafusion-cli and the core library.
   > 
   > Maybe we can just solve the human error part with comments in the queries. 
I'll give that a try later today so we can compare results
   > 
   > Thank you so much @zhuqi-lucas for debugging this
   
   Thank you @alamb for review, i agree it will make diverge datafusion-cli and 
the core library, i am wandering if we can make the following config default to 
true, so it will not have diverge for all default cases:
   
   ```rust
     /// (reading) If true, parquet reader will read columns of
           /// `Binary/LargeBinary` with `Utf8`, and `BinaryView` with 
`Utf8View`.
           ///
           /// Parquet files generated by some legacy writers do not correctly 
set
           /// the UTF8 flag for strings, causing string columns to be loaded as
           /// BLOB instead.
           pub binary_as_string: bool, default = false
   ```
   
   Now it default to false, but  i am not sure if it will make other things 
broken.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to