Dandandan commented on PR #16599: URL: https://github.com/apache/datafusion/pull/16599#issuecomment-3015708840
> Here is a proposed alternative: > > * [Add comments to ClickBench queries about setting binary_as_string #16605](https://github.com/apache/datafusion/pull/16605) > > > As mentioned earlier, I worder though if most of the query performance might be solved by moving the cast out of the filter for string filters (converting the string literal to binary literal in the filter instead)? > > I vaguely remember we tried this but hit some issue -- like I think the `like` kernels only work on `utf8` -- https://docs.rs/arrow/latest/arrow/compute/kernels/comparison/fn.like.html or something similar to that > > So we would have to define what it means to apply a `like` on a binary column hm yeah that makes sense, perhaps we could find out what we need instead. I guess it would be relatively powerful with predicate pushdown as well: we don't have to decode / validate the data in order to filter it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
