Dandandan commented on PR #16599: URL: https://github.com/apache/datafusion/pull/16599#issuecomment-3015377418
I agree, we should default by doing the correct thing. the binary_as_string is a nice thing for fixing the benchmark, but by default we shouldn't do it. As mentioned earlier, I worder though if most of the query performance might be solved by moving the cast out of the filter for string filters (converting the string literal to binary literal in the filter instead)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
