findepi commented on PR #16681: URL: https://github.com/apache/datafusion/pull/16681#issuecomment-3088768792
@alamb https://github.com/apache/datafusion/pull/16781 aims to solve immediate obvious problem - incorrect implementation of equality for stateful functions managed in this repo. That PR does not solve #16677. This PR aims to solve the problem of equality being error-prone, wrong by default. I.e. addresses #16677. The #16781 PR shows how wide-spread the problem is, giving more motivation to fix the default behavior. My proposal is 1. land #16781 (or equivalent), i.e. fix the immediate problem 2. remove default implementation of equality -- this is a breaking change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
