findepi commented on PR #16842: URL: https://github.com/apache/datafusion/pull/16842#issuecomment-3097009055
This is POC only for now. @alamb @kosiew @timsaucer PTAL and let me know if you agree with the direction. Note the PR goals: - reduce complexity of existing code, by deriving `ScalarUDFImpl::equals` and `ScalarUDFImpl::hash_code` from `PartialEq` and `Hash` implementations (same for `AggregateUDFImpl` and `WindowUDFImpl`) - if we decide to remove default implementations of `ScalarUDFImpl::equals` and `ScalarUDFImpl::hash_code` (https://github.com/apache/datafusion/issues/16677), something like this would be even more valuable. If we decide to keep them, it's still a good change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
