alamb commented on code in PR #16842: URL: https://github.com/apache/datafusion/pull/16842#discussion_r2219930888
########## datafusion/expr/src/utils.rs: ########## @@ -1260,6 +1260,24 @@ pub fn collect_subquery_cols( }) } +#[macro_export] +macro_rules! udf_equals_hash { Review Comment: Is this macro needed if we proceed with the proposal in https://github.com/apache/datafusion/issues/16677#issuecomment-3092338265 ? It seems like that proposal is pretty awesome -- is it possible to do incrementally, or does it require one massive PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org