findepi commented on code in PR #16842:
URL: https://github.com/apache/datafusion/pull/16842#discussion_r2220229050
##########
datafusion/expr/src/utils.rs:
##########
@@ -1260,6 +1260,24 @@ pub fn collect_subquery_cols(
})
}
+#[macro_export]
+macro_rules! udf_equals_hash {
Review Comment:
> Is this macro needed if we proceed with the proposal in [#16677
(comment)](https://github.com/apache/datafusion/issues/16677#issuecomment-3092338265)
?
No
But it's a good transition step.
It allows us to introduce PartialEq, Hash implementations for functions
where PartialEq, Hash may not be trivial (`Hashmap`, ``Arc<Fn>``).
On the usage side, the temporary `udf_equals_hash!(...)` line is low cost
for that and easy to remove in the second step.
> It seems like that proposal is pretty awesome -- is it possible to do
incrementally, or does it require one massive PR ?
The change proposed in this PR -- delegation to PartialEq, Hash with
`udf_equals_hash` macro -- can be incremental.
The change proposed in
https://github.com/apache/datafusion/issues/16677#issuecomment-3092338265 is
not incremental.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
