kosiew commented on code in PR #16842:
URL: https://github.com/apache/datafusion/pull/16842#discussion_r2230100602
##########
datafusion/expr/src/utils.rs:
##########
@@ -1260,6 +1261,42 @@ pub fn collect_subquery_cols(
})
}
+/// Generates implementation of `equals` and `hash_value` methods for a trait,
delegating
+/// to PartialEq and Hash implementations on Self.
+/// Meant to be used with traits representing user-defined functions (UDFs).
+#[macro_export]
+macro_rules! udf_equals_hash {
Review Comment:
I think detailed usage guidance will make this macro more usable. Document
its requirements (implementors must provide PartialEq, and Hash) and include a
short example in utils.rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
