NGA-TRAN opened a new pull request, #16858:
URL: https://github.com/apache/datafusion/pull/16858
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #16772
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Serialization and deserialization of physical plans are currently
incomplete. This PR introduces the necessary fixes to ensure all TPC-H queries
pass.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
**Summary of Changes:**
1. Introduced pretty_assertions in the proto crate to highlight test output
differences more clearly. This addition aids debugging, though I’m open to
reverting it if it noticeably impacts crate size.
2. Resolved the missing aggregate in human_display by adding a corresponding
field to the proto definition.
3. Corrected the date_part display function by introducing a new proto field
to handle it properly.
4. Fixed the issue of extra [] in non-group-by aggregates by checking for
empty group-by conditions.
5. Enabled roundtrip tests for all TPC-H queries to ensure correctness and
completeness.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
6. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes
- Added three targeted tests—one for each case—using minimal queries to
isolate issues effectively.
- You're encouraged to copy these tests into your main branch before
applying the fix to confirm that they fail as expected.
- Also enabled all currently available TPC-H tests to ensure comprehensive
coverage.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
The explain for the roundtrip query is now more accurate
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
