NGA-TRAN commented on code in PR #16858:
URL: https://github.com/apache/datafusion/pull/16858#discussion_r2223805868
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -859,6 +859,7 @@ message PhysicalScalarUdfNode {
optional bytes fun_definition = 3;
datafusion_common.ArrowType return_type = 4;
bool nullable = 5;
+ string return_field_name = 6;
Review Comment:
Fix for bug 3 that does not serialize ScarlarFunction name
##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -1819,10 +1823,7 @@ async fn test_serialize_deserialize_tpch_queries() ->
Result<()> {
Ok(())
}
-// bug: https://github.com/apache/datafusion/issues/16772
-// Only 4 queries pass: q3, q5, q10, q12
-// Ignore the test until the bug is fixed
-#[ignore]
+// Bugs: https://github.com/apache/datafusion/issues/16772
Review Comment:
Turn on all 22 tpc-h queries
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -870,6 +871,7 @@ message PhysicalAggregateExprNode {
bool distinct = 3;
bool ignore_nulls = 6;
optional bytes fun_definition = 7;
+ string human_display = 8;
Review Comment:
Fix for bug 1 that does not serialize human_display for aggregate function
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1358,6 +1358,9 @@ impl DefaultPhysicalPlanner {
physical_name(expr),
))?])),
}
+ } else if group_expr.is_empty() {
+ // No GROUP BY clause - create empty PhysicalGroupBy
+ Ok(PhysicalGroupBy::new(vec![], vec![], vec![]))
Review Comment:
One of the place that fixes bug 2 that should return nothing for non-groupby
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
